diff --git a/README.md b/README.md index 6a08a2a..17e1397 100644 --- a/README.md +++ b/README.md @@ -68,9 +68,6 @@ In CMakeLists.txt: # Make sure to find-package `catkin_virtualenv` find_package(catkin REQUIRED ... catkin_virtualenv ...) -# Must be called before catkin_generate_virtualenv -catkin_package() - # Generate the virtualenv catkin_generate_virtualenv() diff --git a/catkin_virtualenv/cmake/catkin_generate_virtualenv.cmake b/catkin_virtualenv/cmake/catkin_generate_virtualenv.cmake index 6c3c1f8..0dc1a42 100644 --- a/catkin_virtualenv/cmake/catkin_generate_virtualenv.cmake +++ b/catkin_virtualenv/cmake/catkin_generate_virtualenv.cmake @@ -57,8 +57,10 @@ function(catkin_generate_virtualenv) return() endif() - ### Start building virtualenv + # Make sure CATKIN_* paths are initialized + catkin_destinations() # oh the places we'll go + ### Start building virtualenv set(venv_dir venv) set(venv_devel_dir ${CATKIN_DEVEL_PREFIX}/${CATKIN_PACKAGE_SHARE_DESTINATION}/${venv_dir}) diff --git a/test_catkin_virtualenv/CMakeLists.txt b/test_catkin_virtualenv/CMakeLists.txt index 4927c96..c907670 100644 --- a/test_catkin_virtualenv/CMakeLists.txt +++ b/test_catkin_virtualenv/CMakeLists.txt @@ -3,12 +3,13 @@ project(test_catkin_virtualenv) find_package(catkin REQUIRED COMPONENTS catkin_virtualenv) -catkin_package() - catkin_generate_virtualenv( INPUT_REQUIREMENTS requirements.in ) +# Order with catkin_generate_virtualenv shouldn't matter +catkin_package() + install(FILES requirements.txt DESTINATION ${CATKIN_PACKAGE_SHARE_DESTINATION})