Stats are reset when re-balancing users across slave nodes

[heyman]

When running locust with --reset-stats in distributed mode, the stats are reset every time a new slave connects (when the re-balancing of the simulated users occur). The stats should only be reset when the initial hatching is complete, and not when re-balancing users.

[max-rocket-internet]

I am not using --reset-stats option, I'm using the default docker image locustio/locust:0.13.1 and locust is started like this:

# Slave
/usr/local/bin/python /usr/local/bin/locust --slave --locustfile=/mnt/locust/main.py --host=https://xxxxx.com --master-host=locust-xxx

# Master
/usr/local/bin/python /usr/local/bin/locust --master --locustfile=/mnt/locust/main.py --host=https://xxxxx.com

But I still see this issue 🙂

[heyman]

Hm, that's strange. I'm not able to reproduce the issue without --reset-stats. I guess I have to do some more digging (I'll try and see if I can reproduce it using the Docker image).

[max-rocket-internet]

OK let me know if you want me to debug or test something.

[matti]

I'm also having the same issue as @max-rocket-internet

[max-rocket-internet]

Still seeing this in version 0.13.5:

[carstendev]

I was able to replicate this or a (related?) issue, by doing the following:

• Start a test without --reset-stats with 500 max users and a hatch rate of 1
• Lower the number of max users after one minute (still during the hatching phase) to 450

Locust then proceeds to calculate users_to_kill = 500 - 450 and kills 50 users immediately.

Issue here is that as the hatching is still ongoing, and 50 of the at this point only 60 spawned users are killed. I would expect locust to kill users based on the actual spawned users, not just the max setting.

If this is in fact not the same issue, I can also open another issue for this.

[heyman]

I've managed to reproduce the issue using the steps described by @carstendev. It's actually a different issue than the original post, but with similar symptoms.

I'm working on a fix now.

[heyman]

I've now pushed changes (576f7ea) that should hopefully fix this. Would be great if someone could try out the latest master to confirm that the issue has been fixed.

[carstendev]

I've tried to reproduce the issue with the latest master, but it seems to be fixed now 👍.

[max-rocket-internet]

Awesome, thanks @heyman!