-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stats are reset when re-balancing users across slave nodes #1168
Comments
I am not using
But I still see this issue 🙂 |
Hm, that's strange. I'm not able to reproduce the issue without --reset-stats. I guess I have to do some more digging (I'll try and see if I can reproduce it using the Docker image). |
OK let me know if you want me to debug or test something. |
I'm also having the same issue as @max-rocket-internet |
I was able to replicate this or a (related?) issue, by doing the following:
Locust then proceeds to calculate Issue here is that as the hatching is still ongoing, and 50 of the at this point only 60 spawned users are killed. I would expect locust to kill users based on the actual spawned users, not just the max setting. If this is in fact not the same issue, I can also open another issue for this. |
I've managed to reproduce the issue using the steps described by @carstendev. It's actually a different issue than the original post, but with similar symptoms. I'm working on a fix now. |
…sers are still hatching. #1168 Removed LocustRunner.num_clients in favour of using LocustRunner.user_count which should be less prone to errors (since it’s the actual number of locust greenlets). Introduced MasterLocustRunner.target_user_count which is needed so that we can rebalance locust users across the connected slaves while users are till hatching.
I've now pushed changes (576f7ea) that should hopefully fix this. Would be great if someone could try out the latest master to confirm that the issue has been fixed. |
I've tried to reproduce the issue with the latest master, but it seems to be fixed now 👍. |
Awesome, thanks @heyman! |
When running locust with
--reset-stats
in distributed mode, the stats are reset every time a new slave connects (when the re-balancing of the simulated users occur). The stats should only be reset when the initial hatching is complete, and not when re-balancing users.The text was updated successfully, but these errors were encountered: