Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error percentage cli output #1082

Merged

Conversation

@raiyankamal
Copy link
Contributor

commented Sep 6, 2019

Following up after the conversation in this PR: #1075

Code changes as suggested in disucssion. Requesting review @aldenpeterson-wf @cgoldberg

Added unit tests.

EDIT: force push after removing whitespace changes and rebasing onto latest master.

@raiyankamal raiyankamal referenced this pull request Sep 6, 2019

@raiyankamal raiyankamal force-pushed the raiyankamal:fix-error-percentage-cli-output branch from 4204c2a to 54b676c Sep 6, 2019

Zach Martin and others added 2 commits Aug 27, 2019
Fix fail percentage
The fail percentage was calculated incorrectly. Something that failed
all of the time would be reported as failing 50% total.

@raiyankamal raiyankamal force-pushed the raiyankamal:fix-error-percentage-cli-output branch from 54b676c to 97dc3de Sep 6, 2019

@JesseRhoads

This comment has been minimized.

Copy link

commented Sep 7, 2019

+1 to this, it has fixed the display issue. Please merge :)

pep8 fix
added spacing
@cgoldberg
Copy link
Member

left a comment

👍 LGTM, thanks for including tests!

Note: I updated your branch with a small fix and will merge now.

@cgoldberg cgoldberg merged commit 610a87f into locustio:master Sep 7, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.