Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add p99.9 and p99.99 to request stats distribution csv #1125

Merged

Conversation

@cyberw
Copy link
Contributor

cyberw commented Oct 26, 2019

Solves #1040

@heyman

This comment has been minimized.

Copy link
Member

heyman commented Oct 27, 2019

Nice! Wouldn't mind a line about this in the Documentation's Changelog either (changelog.rst).

@heyman

This comment has been minimized.

Copy link
Member

heyman commented Oct 27, 2019

Currently this PR also changes the percentile stats that is outputted to the console when the test finishes in --no-web mode. That's why the tests are failing I think.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 28, 2019

Codecov Report

Merging #1125 into master will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1125   +/-   ##
=======================================
  Coverage   74.47%   74.47%           
=======================================
  Files          18       18           
  Lines        1802     1802           
  Branches      269      269           
=======================================
  Hits         1342     1342           
  Misses        393      393           
  Partials       67       67
Impacted Files Coverage Δ
locust/stats.py 82.04% <66.66%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e5a8ee...214281a. Read the comment docs.

@cyberw

This comment has been minimized.

Copy link
Contributor Author

cyberw commented Oct 28, 2019

Won't the change log get the ticket added automatically?

cyberw added 2 commits Oct 28, 2019
@heyman

This comment has been minimized.

Copy link
Member

heyman commented Oct 28, 2019

Won't the change log get the ticket added automatically?

It will be added to the auto-generated CHANGELOG.md, but the Changelog Highlights in the documentation is manually curated: https://docs.locust.io/en/latest/changelog.html

cyberw added 2 commits Oct 29, 2019
…p99.9-and-p99.99-to-stats-distribution-csv

# Conflicts:
#	docs/changelog.rst
@cyberw

This comment has been minimized.

Copy link
Contributor Author

cyberw commented Oct 30, 2019

@heyman Ok to merge?

@heyman

This comment has been minimized.

Copy link
Member

heyman commented Oct 30, 2019

Yes! Nice!

@heyman heyman merged commit cbf2834 into locustio:master Oct 30, 2019
2 of 3 checks passed
2 of 3 checks passed
codecov/patch 66.66% of diff hit (target 74.47%)
Details
codecov/project 74.47% remains the same compared to 5e5a8ee
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.