Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and fix delayed user stopping in combination with on_stop #1560

Conversation

cyberw
Copy link
Collaborator

@cyberw cyberw commented Sep 15, 2020

Fixes #1552

cyberw added 4 commits Sep 15, 2020
…g callers of User.stop() specify it. Add some type hints.
… places, and (because its main use is to throw an exception) it makes things a little hard to understand.
Rename a test case.
@codecov
Copy link

codecov bot commented Sep 15, 2020

Codecov Report

Merging #1560 into master will increase coverage by 0.47%.
The diff coverage is 96.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1560      +/-   ##
==========================================
+ Coverage   81.98%   82.45%   +0.47%     
==========================================
  Files          28       28              
  Lines        2564     2570       +6     
  Branches      392      392              
==========================================
+ Hits         2102     2119      +17     
+ Misses        363      360       -3     
+ Partials       99       91       -8     
Impacted Files Coverage Δ
locust/runners.py 84.05% <92.85%> (+2.26%) ⬆️
locust/user/task.py 97.83% <100.00%> (+1.08%) ⬆️
locust/user/users.py 95.83% <100.00%> (ø)
locust/stats.py 89.87% <0.00%> (-0.81%) ⬇️
locust/contrib/fasthttp.py 86.32% <0.00%> (+0.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 532f33a...2c1cdcf. Read the comment docs.

@cyberw cyberw merged commit 6871e6b into master Sep 16, 2020
@cyberw cyberw deleted the refactor-and-fix-delayed-user-stopping-in-combination-with-on_stop branch Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On Stop causes the task to continue
1 participant