Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure runner.quit finishes even when users are broken #1728

merged 2 commits into from Mar 11, 2021


Copy link

@cyberw cyberw commented Mar 11, 2021

Workaround for #1726

This should change it from throwing an exception (and thus failing to stop), to instead logging an error message and then moving on (havent been able to test it 100% though). May give us some more info for a proper fix as well.

[2021-03-11 12:54:24,150] Shutting down (exit code 0), bye.
[2021-03-11 12:54:24,150] Cleaning up runner...
[2021-03-11 12:54:24,150] Found a user that didnt have proper args <Greenlet "Greenlet-0" at 0x112c863b0: run_user(<player_settings.WebUser object at 0x112b1f650>)>

@cyberw cyberw merged commit f61ae7d into master Mar 11, 2021
@cyberw cyberw deleted the ensure-runner.quit-finishes-even-when-users-are-broken branch March 22, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant