Repository navigation
Upgrade to flask 2 - #1764
Upgrade to flask 2#1764
Conversation
|
Cool stuff! Right now there is just so much more flask 1.x running out there (that people might be running in the same env as locust or inside locust), so I dont think we want to merge this right now, but it is nice to know we can. |
Thanks for the feedback :) Maybe I can add conditions to see which version of Flask is used and adapt the changes depending on this, to allow running with both Flask 1.x and Flask 2.x ? |
That would be nice. We'd still have to depend on 1.x in setup.py, but I guess it might still be useful for some people. |
|
Actually, I'm thinking about making a 2.0 release soon and it makes total sense to update flask at the same time. can you fix the formatting errors though? |
Sure ! I just pushed an update with formatting fixed. I didn't have time to verify the tests though, but look like they are OK on the CI. |
|
Thanks for the PR. I ran into this error just now when I try to run locust. It was working for me a few hours ago, then all in sudden ran into this error. Nothing has changed on my side. |
I want to do this in 2.0, because it may be a breaking change for some people. Locust 1.5.3 uses a pinned 1.x version of Flask, so you shouldnt have this issue? |
Ah my locust is 1.4.4. I'll update and see if it works. Thank you! |
update to 1.5.3 fixed my problem. Thank you! |
I noticed in issue #1759 that the flask version was pinned to the 1.x branch to fix compatibility issues. This PR introduces the necessary changes to bump Flask and werkzeug to version 2.x .