Fire test_start and test_stop events on worker nodes #1777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Looks great! However, this is a breaking change (for people relying on test_start not being triggered on master), so I will not merge it just now (in case we need to make another 1.x release). My guess is that we'll release 2.0 in a month or so, so I'll merge this in a couple of weeks at the latest. |
Contributor
Author
|
Are planned version 2.0 changes documented anywhere? I have some more changes I'd like to implement and wanted to make sure I didn't double up on work |
Collaborator
|
Not really. Just the open PR about user spawning |
Collaborator
|
@nathan-beam Can I bother you to resolve the conflicts? |
Collaborator
|
@nathan-beam I'd love to have this as part of 2.0 (as it is a breaking change), but I can't be arsed to resolve the conflicts :) |
Contributor
Author
|
@cyberw should be g2g now |
Contributor
Author
|
nvm |
Contributor
Author
|
Ok now it's good to go |
Collaborator
|
Thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to fix #1776
Added
test_startandtest_stopevents to the baseRunnerclass'start()andstop()method, respectivelyAdded/updated relevant tests and documentation.