Skip to content

Remove user_classes_count from heartbeat payload#1825

Merged
cyberw merged 3 commits intolocustio:masterfrom
mboutet:feature/remove-users-from-heartbeat
Jul 28, 2021
Merged

Remove user_classes_count from heartbeat payload#1825
cyberw merged 3 commits intolocustio:masterfrom
mboutet:feature/remove-users-from-heartbeat

Conversation

@mboutet
Copy link
Copy Markdown
Contributor

@mboutet mboutet commented Jul 25, 2021

user_classes_count is already part of the stats payload so having it in the heartbeat payload is redundant and makes the payload larger.

TODO:

  • Add/update test to validate the content of the heartbeat payload

`user_classes_count` is already part of the stats payload so having it in the heartbeat payload is redundant and makes the payload larger.
@cyberw
Copy link
Copy Markdown
Collaborator

cyberw commented Jul 25, 2021

You should probably also remove these lines from runner.py (910-912):

                    user_classes_count = msg.data.get("user_classes_count")
                    if user_classes_count:
                        c.user_classes_count = user_classes_count

@cyberw
Copy link
Copy Markdown
Collaborator

cyberw commented Jul 28, 2021

ok to merge? (you still have it marked as draft)

@mboutet mboutet marked this pull request as ready for review July 28, 2021 20:15
@mboutet
Copy link
Copy Markdown
Contributor Author

mboutet commented Jul 28, 2021

Yes

@cyberw cyberw merged commit b063df8 into locustio:master Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants