Remove user_classes_count from heartbeat payload#1825
Merged
cyberw merged 3 commits intolocustio:masterfrom Jul 28, 2021
Merged
Remove user_classes_count from heartbeat payload#1825cyberw merged 3 commits intolocustio:masterfrom
user_classes_count from heartbeat payload#1825cyberw merged 3 commits intolocustio:masterfrom
Conversation
`user_classes_count` is already part of the stats payload so having it in the heartbeat payload is redundant and makes the payload larger.
Collaborator
|
You should probably also remove these lines from runner.py (910-912): |
Collaborator
|
ok to merge? (you still have it marked as draft) |
Contributor
Author
|
Yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
user_classes_countis already part of the stats payload so having it in the heartbeat payload is redundant and makes the payload larger.TODO: