Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging messages and clean up code after dispatch refactoring (#1809) #1826

Merged
merged 10 commits into from Jul 28, 2021

Conversation

mboutet
Copy link
Contributor

@mboutet mboutet commented Jul 28, 2021

This is the continuation of PR #1809 to address the TODOs and comments that were left on this other PR. PR #1809 was merged in an imperfect (but working) state in order to release another beta of Locust and get feedback from the community as soon as possible.

@cyberw cyberw changed the title Continuation of PR #1809 Improve logging messages and clean up code after dispatch refactoring (#1809) Jul 28, 2021
@cyberw
Copy link
Collaborator

cyberw commented Jul 28, 2021

let me know when you feel ready to merge. with this + the change in heartbeat messages I think we have enough for another (last?) beta build.

@mboutet
Copy link
Contributor Author

mboutet commented Jul 28, 2021

Yes, I'm adding the test for the len(workers) == 0 and should push something soon.

Also add more assertions for `UsersDispatcher._rebalance` in dispatch tests.
@mboutet
Copy link
Contributor Author

mboutet commented Jul 28, 2021

I think this is ready

@mboutet mboutet marked this pull request as ready for review July 28, 2021 20:15
@cyberw cyberw merged commit 04aef2f into locustio:master Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants