Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw exception when calling response.success()/.failure() if with-block has not been entered #1955

Merged
merged 4 commits into from Dec 8, 2021

Conversation

cyberw
Copy link
Collaborator

@cyberw cyberw commented Dec 8, 2021

For when catch_response=True is set, but someone forgot to do a with-block...

… without using a with block. Committing tests-first for validation.
@cyberw cyberw force-pushed the throw-exception-on-missing-with-block branch 3 times, most recently from 5c0b397 to 3499230 Compare December 8, 2021 10:30
…s() without using a with block (helps with some misunderstandings, e.g. #1953)
@cyberw cyberw force-pushed the throw-exception-on-missing-with-block branch from 3499230 to ceb2cf2 Compare December 8, 2021 10:42
@cyberw cyberw merged commit 581e1de into master Dec 8, 2021
@cyberw cyberw deleted the throw-exception-on-missing-with-block branch March 22, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant