Conversation
… without using a with block. Committing tests-first for validation.
cyberw
force-pushed
the
throw-exception-on-missing-with-block
branch
3 times, most recently
from
5c0b397 to
3499230
Compare
…s() without using a with block (helps with some misunderstandings, e.g. #1953)
cyberw
force-pushed
the
throw-exception-on-missing-with-block
branch
from
3499230 to
ceb2cf2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For when
catch_response=Trueis set, but someone forgot to do a with-block...