Support sharing connection pools between users#2059
Merged
Conversation
Collaborator
|
Cool stuff. A few test cases would be nice, ideally one that actually verifies somehow that connections are really pooled. And we’d need to add it to the docs somewhere. |
Contributor
Author
|
@cyberw PTAL. I have no idea why mypy reported that error, because I didn't touch |
Contributor
Author
|
Now black is failing due to psf/black#2964. |
Collaborator
|
Thx! I think merging will get us the fix needed for >3.6 builds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for sharing connection pools between users. It is done by exposing lower level pool (
urllib3.PoolManagerforHttpUser,geventhttpclient.client.HTTPClientPoolforFastHttpUser).Example usage:
Fixes #1925.