dispatch: rebalance users with a fixed count#2093
Merged
cyberw merged 1 commit intolocustio:masterfrom May 9, 2022
andydunstall:bugfix/2091-fixed-count-users-not-rebalanced
Merged
dispatch: rebalance users with a fixed count#2093cyberw merged 1 commit intolocustio:masterfrom andydunstall:bugfix/2091-fixed-count-users-not-rebalanced
cyberw merged 1 commit intolocustio:masterfrom
andydunstall:bugfix/2091-fixed-count-users-not-rebalanced
Conversation
Contributor
Collaborator
|
Lgtm, but @mboutet is the user distribution expert :) |
Contributor
|
LGTM also! Thank you all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2091
_user_gencompares the expected number of fixed count users with the users inself._users_on_workersself._try_dispatch_fixed = Trueto include fixed users in the rebalanceTestAddWorkerandTestRemoveWorkerto add a test for fixed count (which both fail without this commit) - these just copytest_remove_worker_during_ramp_upandtest_add_worker_during_ramp_upwith a fixed user