Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dispatch: rebalance users with a fixed count #2093

Merged
merged 1 commit into from
May 9, 2022
Merged

dispatch: rebalance users with a fixed count #2093

merged 1 commit into from
May 9, 2022

Conversation

andydunstall
Copy link
Contributor

Fixes #2091

  • Resets the user worker count before rebalancing since _user_gen compares the expected number of fixed count users with the users in self._users_on_workers
  • Sets self._try_dispatch_fixed = True to include fixed users in the rebalance
  • Extends TestAddWorker and TestRemoveWorker to add a test for fixed count (which both fail without this commit) - these just copy test_remove_worker_during_ramp_up and test_add_worker_during_ramp_up with a fixed user

@EzR1d3r
Copy link
Contributor

EzR1d3r commented May 8, 2022

Looks fine. @cyberw @mboutet can you review too?

@cyberw
Copy link
Collaborator

cyberw commented May 8, 2022

Lgtm, but @mboutet is the user distribution expert :)

@mboutet
Copy link
Contributor

mboutet commented May 8, 2022

LGTM also! Thank you all.

@cyberw cyberw merged commit 61cb0cd into locustio:master May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Users with fixed_count not being relocated after rebalance
4 participants