Conversation
…s correctly with Browserify
…ve `codez` replace hack
…untObj.value` and `errorObj.value` instead
and change all functions accordingly
So we don't have to have any Ruby dependencies Squashed commit of the following: commit da192c6 Author: Kevin van Zonneveld <kevin@vanzonneveld.net> Date: Mon May 2 15:51:21 2016 +0200 Rename `_locutus_shared` to `_helpers`. Rename `_locutus_shared_bc` to `_bc` commit 59b68d7 Author: Kevin van Zonneveld <kevin@vanzonneveld.net> Date: Mon May 2 14:12:38 2016 +0200 Fix tests commit b5f87be Author: Kevin van Zonneveld <kevin@vanzonneveld.net> Date: Mon May 2 11:09:14 2016 +0200 Bla commit f7875a0 Author: Kevin van Zonneveld <kevin@vanzonneveld.net> Date: Mon May 2 10:16:11 2016 +0200 WIP commit 5b029f8 Author: Kevin van Zonneveld <kevin@vanzonneveld.net> Date: Sun May 1 23:23:08 2016 +0200 Fix jumpy scrolling due to on the githubs commit 148a5ab Author: Kevin van Zonneveld <kevin@vanzonneveld.net> Date: Sun May 1 23:05:36 2016 +0200 Add package type commit c7822cf Author: Kevin van Zonneveld <kevin@vanzonneveld.net> Date: Sun May 1 21:12:30 2016 +0200 Port add more commit 8eea314 Author: Kevin van Zonneveld <kevin@vanzonneveld.net> Date: Sun May 1 20:35:51 2016 +0200 Ported function layout commit 2685b9c Author: Kevin van Zonneveld <kevin@vanzonneveld.net> Date: Sun May 1 19:25:30 2016 +0200 Fix authors commit 08557f4 Author: Kevin van Zonneveld <kevin@vanzonneveld.net> Date: Sun May 1 16:16:32 2016 +0200 WIP commit d4b3ae0 Author: Kevin van Zonneveld <kevin@vanzonneveld.net> Date: Sun May 1 12:20:35 2016 +0200 update commit e848be6 Author: Kevin van Zonneveld <kevin@vanzonneveld.net> Date: Sun May 1 11:59:17 2016 +0200 Better injection commit 5a14b88 Author: Kevin van Zonneveld <kevin@vanzonneveld.net> Date: Sun May 1 11:52:59 2016 +0200 WIP commit 77966c4 Author: Kevin van Zonneveld <kevin@vanzonneveld.net> Date: Sun May 1 11:45:11 2016 +0200 Source commit 100ee7f Author: Kevin van Zonneveld <kevin@vanzonneveld.net> Date: Sun May 1 11:35:54 2016 +0200 WIP commit 000e0ae Author: Kevin van Zonneveld <kevin@vanzonneveld.net> Date: Sun May 1 10:21:27 2016 +0200 Add icarus theme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are a few of the things I have been working on in order to clean up our codebase and breathe new life into this project:
$globalthat works in both Browsers and Node.js (we should try to avoid this when we can though)eval,new Functionand other bad practicesrequirenpm installed_workbenchand_experimentalfolders. They are available for reference in 1.3.2, but making them harder to find for newcomers should help avoid complaints and confusion. If you want to experiment, we can use local files or branches when it's time to collaborate.