New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support explicit, terminated chain sequences. #176

Merged
merged 1 commit into from Nov 17, 2017

Conversation

9 participants
@mickylad
Contributor

mickylad commented Jun 19, 2017

This does some work towards #92 - I've not had time yet to figure out if or how unterminated chains might be handled, as well as imlpicit chains.

Would be good to know if this is something you'd be willing to merge, I know you said you would accept a PR on #92 but obviously this doesn't cover all cases, at least yet.

If you do have thoughts on how unterminated and implicit chains could be handled, I'd be glad to hear them and see if I can make any more progress.

@jsf-clabot

This comment has been minimized.

jsf-clabot commented Jun 19, 2017

CLA assistant check
All committers have signed the CLA.

@jdalton jdalton added the enhancement label Jun 19, 2017

@jdalton

This comment has been minimized.

Member

jdalton commented Jun 19, 2017

Whoa! So awesome! 🎉

@lukeapage

This comment has been minimized.

lukeapage commented Jun 19, 2017

I'd be happy to see this merged as is, we could start using the plugin but we would enforce no unterminated or implicit chaining.

Does it need rebasing? Looks like it picked up unintentional commits.

@mickylad

This comment has been minimized.

Contributor

mickylad commented Jun 20, 2017

Ah yes, will rebase!

@mickylad

This comment has been minimized.

Contributor

mickylad commented Jun 20, 2017

Rebased

@lukeapage

This comment has been minimized.

lukeapage commented Jun 30, 2017

@jdalton any chance of getting this merged or reviewed soon?

@jdalton

This comment has been minimized.

Member

jdalton commented Jun 30, 2017

Hi @lukeapage!

I have my head down with the WIP esm loader at the moment.

@adierkens

This comment has been minimized.

adierkens commented Aug 10, 2017

Any update on this?

@laander

This comment has been minimized.

laander commented Aug 25, 2017

Bump on this, would be amazeballs to get out! ⚡️

@rkrueger11

This comment has been minimized.

rkrueger11 commented Nov 16, 2017

what about now? 😁

@mickylad

This comment has been minimized.

Contributor

mickylad commented Nov 17, 2017

@jdalton I've pushed an up-to-date version of this. I noticed you've updated your code style - I tried to bring my changes inline with that, so let me know if there's anything I've missed!

@jdalton

This comment has been minimized.

Member

jdalton commented Nov 17, 2017

@mickylad Thank you! Yeah, my code style tends to change based on the last project I worked on. There is now a clash of styles I'll be dealing with 😋

@jdalton jdalton merged commit 098ccb9 into lodash:master Nov 17, 2017

2 checks passed

Node Security No known vulnerabilities found
Details
licence/cla Contributor License Agreement is signed.
Details
@jdalton

This comment has been minimized.

Member

jdalton commented Nov 17, 2017

🎉 🎉 🎉

@mickylad

This comment has been minimized.

Contributor

mickylad commented Nov 17, 2017

I know the feeling! Thanks! :)

@hipstersmoothie

This comment has been minimized.

hipstersmoothie commented Jan 16, 2018

Can we get a release?

@hipstersmoothie

This comment has been minimized.

hipstersmoothie commented Feb 21, 2018

are we gonna get a release in 2018? @mickylad @jdalton @anyone-who-cares

@lukeapage

This comment has been minimized.

lukeapage commented Feb 21, 2018

I care.. am waiting to use it, though if I get the time I will just publish it privately, so this is an annoyance but not a blocker.

@alisowski54

This comment has been minimized.

alisowski54 commented May 29, 2018

@jdalton

This comment has been minimized.

Member

jdalton commented May 29, 2018

Even thought it was ultimately reverted I'm very thankful to @mickylad for putting the time into this and its follow-up PR!

Related to #210 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment