isEmpty(new Date) returns true instead of false

[dellyoung]

_.isEmpty(new Date)

Actual returns:

true

Expected:

false

[dellyoung]

PR

[Tracer1337]

Why do you expect false here? I would consider an empty Date object as an object without a timestamp, but that does not exist (as far as I know).

[graup]

According to the documentation, "objects are considered empty if they have no own enumerable string keyed properties." Thus IMO true is the expected value for isEmpty(new Date) as a date is an object with no own properties.

[Tracer1337]

Considering the Object.getOwnPropertyNames methods, all Date objects are empty

> Object.getOwnPropertyNames(new Date)
[]
> Object.getOwnPropertyNames(new Date())
[]
> Object.getOwnPropertyNames(new Date("01.01.2021"))
[]

That is also counterintuitive.

[jdalton]

According to the documentation, "objects are considered empty if they have no own enumerable string keyed properties." Thus IMO true is the expected value for isEmpty(new Date) as a date is an object with no own properties.

Yes. This method name has always carried with it some confusion. Instead of tweaking the method I think we should rename it. I'm open to PRs for that :)

[dellyoung]

According to the documentation, "objects are considered empty if they have no own enumerable string keyed properties." Thus IMO true is the expected value for isEmpty(new Date) as a date is an object with no own properties.

Yes. This method name has always carried with it some confusion. Instead of tweaking the method I think we should rename it. I'm open to PRs for that :)

Thank you, I was misunderstood by the name, I think it needs to be renamed.