Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't import whole lodash #3450

Closed
srigi opened this issue Oct 26, 2017 · 6 comments
Closed

Don't import whole lodash #3450

srigi opened this issue Oct 26, 2017 · 6 comments
Labels

Comments

@srigi
Copy link

srigi commented Oct 26, 2017

You're importing whole lodash module in your sources just to call one or two methods of it.
Either import individual packages (lodash.forown, lodash.pick) or change deps. to lodash-es and import like

import pick from 'lodash-es/pick'

Otherwise users of this library are penalised that their bundle.js contains whole lodash.js even if they're not using it.

@falsyvalues
Copy link
Contributor

Hi @srigi!

As you may see on master branch lodash v5 will be fully modularized.

@harshes53
Copy link

harshes53 commented Nov 23, 2017

Hi @falsyvalues, I’ve been tracking master branch for sometime, and I’d like to know if we have any milestone set or a rough target release/beta date for v5?

Thanks!

@jdalton
Copy link
Member

jdalton commented Nov 23, 2017

Hi @harshes53!

I try to target January releases for major versions of Lodash.

@falsyvalues
Copy link
Contributor

@harshes53, @jdalton was faster and more accurate I guess ❤️

@harshes53
Copy link

@falsyvalues yes he's active on github.

@jdalton thanks for the heads up mate!

@lock
Copy link

lock bot commented Dec 26, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

No branches or pull requests

4 participants