Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate modular build packages? #3838

Closed
jedwards1211 opened this issue Jun 19, 2018 · 3 comments
Closed

deprecate modular build packages? #3838

jedwards1211 opened this issue Jun 19, 2018 · 3 comments
Labels

Comments

@jedwards1211
Copy link

@jedwards1211 jedwards1211 commented Jun 19, 2018

I recently discovered that all of the lodash.assign, lodash.isstring, lodash.isobject, etc. packages I've been using were larger than I would have expected, and take up quite a bit of space in my webpack bundles, and that I could save plenty of space by requiring lodash/assign, lodash/isString, etc. instead. It seems like all libraries that depend on modular build packages should make this switch. Deprecating would encourage library authors to get the ball rolling on this change. (I have my own jscodeshift script I've been using to make this change to my own packages and would be happy to release it publically).

Or is there something I misunderstand? Do the modular build packages really have any advantages over lodash anymore?

@jdalton jdalton added the question label Jun 20, 2018
@jdalton

This comment has been minimized.

Copy link
Member

@jdalton jdalton commented Jun 20, 2018

Hi @jedwards1211!

(I have my own jscodeshift script I've been using to make this change to my own packages and would be happy to release it publically).

Yes, please release it :D

The individual module packages won't be carried over to Lodash v5. I can't deprecate them with the npm deprecate method since that sends a log to stderr and causes some build scripts to fail. So I will simply let it fade away without a v5 update.

@jdalton jdalton closed this Jun 20, 2018
@jedwards1211

This comment has been minimized.

Copy link
Author

@jedwards1211 jedwards1211 commented Jun 20, 2018

@lock

This comment has been minimized.

Copy link

@lock lock bot commented Jun 20, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
You can’t perform that action at this time.