Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lodash.isEqual returns different result when order of arguments is switched #4320

Closed
capaj opened this issue Jun 7, 2019 · 7 comments
Closed
Labels
bug

Comments

@capaj
Copy link

@capaj capaj commented Jun 7, 2019

As found out by @benjamn here: apollographql/apollo-client#4924 (comment)

here is how it runs in a console on lodash.com:
image

@falsyvalues falsyvalues added the bug label Jun 7, 2019
@miscoder
Copy link

@miscoder miscoder commented Jun 30, 2019

@falsyvalues I'll take this issue.

@benjamn
Copy link

@benjamn benjamn commented Jun 30, 2019

@miscoder I’m sure there are multiple solutions that would work, but here’s one strategy that I settled on. If you like thinking about algorithms, this is a fun one.

@cukejianya
Copy link

@cukejianya cukejianya commented Aug 7, 2019

@miscoder Are you still working on this issue?

@cukejianya
Copy link

@cukejianya cukejianya commented Aug 23, 2019

If it's alright with @miscoder, I would like to take on this issue. Not sure if he is still working on it.

@ccjmne
Copy link

@ccjmne ccjmne commented Oct 6, 2019

It looks like @benjamn pretty much worked out the hard parts already, and @miscoder doesn't seem to have done any progress in the 3+ months he's had the claim to this issue. I think you can go ahead, @cukejianya.
If you aren't interested anymore or don't have the time these days, just let us know 🙂.

@cukejianya
Copy link

@cukejianya cukejianya commented Oct 8, 2019

@ccjmne Sounds good.

@jdalton
Copy link
Member

@jdalton jdalton commented Oct 16, 2019

Closed by #4515.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants
You can’t perform that action at this time.