Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that over* methods accept matches* shortcuts #4510

Closed
arty-name opened this issue Oct 9, 2019 · 2 comments
Closed

Document that over* methods accept matches* shortcuts #4510

arty-name opened this issue Oct 9, 2019 · 2 comments
Labels

Comments

@arty-name
Copy link

@arty-name arty-name commented Oct 9, 2019

I was pleasantly surprised that filter and others can use multiple matchers thanks to over* functions:

_.filter(input, _.overSome([
    _.matches({'a': 1}),
    _.matches({'a': 2}),
]))

Thanks to #2193 this becomes even better:

_.filter(input, _.overSome([
    {'a': 1},
    {'a': 2},
]))

However that last improvement seems to be undocumented. Could you please document this possibility for over* functions? Referring to them in the matches documentation could be the cherry on top.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.