Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove V8 JIT bug fix for isObject #1899

Merged
merged 1 commit into from Jan 29, 2016

Conversation

2 participants
@ooflorent
Copy link
Contributor

commented Jan 29, 2016

This bug has been fixed around 2012-08-15 and has landed in Node 0.8.8.

The workaround is no longer required.

Sources:

Remove V8 JIT bug fix for isObject
This bug has been fixed around 2012-08-15 and
has landed in Node 0.8.8.

The workaround is no longer required.

@jdalton jdalton added the enhancement label Jan 29, 2016

@jdalton

This comment has been minimized.

Copy link
Member

commented Jan 29, 2016

Hi @ooflorent! Have you signed our cla?

@ooflorent

This comment has been minimized.

Copy link
Contributor Author

commented Jan 29, 2016

Yes sure.

Florent Cailhol (ooflorent) submitted a CLA on 2015-05-04 08:15:18.

jdalton added a commit that referenced this pull request Jan 29, 2016

Merge pull request #1899 from ooflorent/isObject/remove_v8_fix
Remove V8 JIT bug fix for isObject

@jdalton jdalton merged commit b4e9411 into lodash:master Jan 29, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jdalton

This comment has been minimized.

Copy link
Member

commented Jan 29, 2016

Rock!

@ooflorent ooflorent deleted the ooflorent:isObject/remove_v8_fix branch Jan 29, 2016

@ooflorent

This comment has been minimized.

Copy link
Contributor Author

commented Feb 3, 2016

I've noticed that this change is no longer part of lodash? Is there any reason? I'm curious to know what went wrong.

@jdalton

This comment has been minimized.

Copy link
Member

commented Feb 3, 2016

I decided to remove the comment but leave the implementation.

@lock

This comment has been minimized.

Copy link

commented Dec 27, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 27, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.