Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

npmignore unneeded files #230

Closed
wants to merge 1 commit into
from

Conversation

2 participants
Contributor

sindresorhus commented Apr 7, 2013

Lots of packages depend on Lodash. This would make it 1.4MB smaller, which would significantly reduce bandwidth overall.

Owner

jdalton commented Apr 8, 2013

Thanks, but no thanks, this would break our build. Our current package size is ~440bytes gz so I'm fine with it the way it is.

@jdalton jdalton closed this Apr 8, 2013

jdalton added a commit that referenced this pull request Apr 8, 2013

Owner

jdalton commented Apr 8, 2013

I tweaked it a bit :D

@sindresorhus sindresorhus deleted the sindresorhus:patch-1 branch Apr 8, 2013

Contributor

sindresorhus commented Apr 8, 2013

Thanks :)

Keep in mind that gzipped helps for bandwidth, but not for disk space. Especially painful for people committing dependencies, where Lodash probably is included many times

Owner

jdalton commented Apr 8, 2013

Keep in mind that gzipped helps for bandwidth, but not for disk space. Especially painful for people committing dependencies, where Lodash probably is included many times

Yap, I hear ya. We've refactored our package in the past to avoid downloading the minifiers. As it is today, I think this is as far as I'm willing to cut it since npm can be used for client or server side w/o distinction. Client-side package managers like JamJS do get a smaller package.

jdalton added a commit that referenced this pull request Aug 29, 2013

Reduce package size. [closes #230]
Former-commit-id: 91e7564f799866453783c9319af405a7aea65b2c

jdalton added a commit that referenced this pull request Sep 1, 2013

Reduce package size. [closes #230]
Former-commit-id: 91e7564f799866453783c9319af405a7aea65b2c

jdalton added a commit that referenced this pull request Sep 25, 2014

Reduce package size. [closes #230]
Former-commit-id: 91e7564f799866453783c9319af405a7aea65b2c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment