Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document matches* shorthands for over* methods (#4510) #4514

Merged
merged 1 commit into from Oct 13, 2019

Conversation

@arty-name
Copy link

@arty-name arty-name commented Oct 11, 2019

In this commit I documented the shorthands added in #2193.

Additionally I updated documentation of _.matches and _.matchesProperty with hints on how to combine predicates.

Also I have hinted on combining the predicates in the documentation of _.filter, arguably the most used iterator.

Open questions:

  1. Is it really possible to combine different types of shorthands?
  2. How exactly should the JSDoc @param be updated for over* methods?
  3. Are you happy with the placement of hints in the documentation?
@jsf-clabot
Copy link

@jsf-clabot jsf-clabot commented Oct 11, 2019

CLA assistant check
All committers have signed the CLA.

lodash.js Outdated Show resolved Hide resolved
@jdalton jdalton merged commit 94c3a81 into lodash:4.17.15-post Oct 13, 2019
1 check passed
1 check passed
licence/cla Contributor License Agreement is signed.
Details
@jdalton
Copy link
Member

@jdalton jdalton commented Oct 13, 2019

Thanks @arty-name!

@arty-name
Copy link
Author

@arty-name arty-name commented Oct 13, 2019

Sweet! Thank you too, @jdalton!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.