Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move attribute containers to a single module #211

Merged
merged 2 commits into from Sep 11, 2019

Conversation

@tomchop
Copy link
Collaborator

commented Aug 30, 2019

No description provided.

@tomchop tomchop requested a review from Onager Aug 30, 2019
@codecov

This comment has been minimized.

Copy link

commented Aug 30, 2019

Codecov Report

Merging #211 into master will decrease coverage by 0.08%.
The diff coverage is 76.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #211      +/-   ##
==========================================
- Coverage   69.26%   69.17%   -0.09%     
==========================================
  Files          28       26       -2     
  Lines        1490     1486       -4     
==========================================
- Hits         1032     1028       -4     
  Misses        458      458
Impacted Files Coverage Δ
dftimewolf/lib/processors/turbinia.py 81.57% <100%> (ø) ⬆️
...ftimewolf/lib/processors/stackdriver_timesketch.py 73.01% <50%> (ø) ⬆️
dftimewolf/lib/collectors/stackdriver.py 37.87% <50%> (ø) ⬆️
dftimewolf/lib/containers/containers.py 80% <80%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d50f5fb...f18893d. Read the comment docs.

@Onager
Onager approved these changes Sep 11, 2019
@Onager Onager merged commit acd8dd5 into log2timeline:master Sep 11, 2019
3 checks passed
3 checks passed
CodeFactor No issues found.
Details
codecov/project Absolute coverage decreased by -0.08% but relative coverage increased by +7.4% compared to d50f5fb
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
predictiple added a commit to predictiple/dftimewolf that referenced this pull request Sep 11, 2019
Moved attribute containers to a single module (log2timeline#211)
@tomchop tomchop deleted the tomchop:attributecontainermodule branch Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.