Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): file appender types #1031

Merged
merged 2 commits into from Jan 10, 2022
Merged

Conversation

vdmtrv
Copy link
Contributor

@vdmtrv vdmtrv commented Jul 11, 2020

The Typescript types are wrong for the File appender. This is related to #807

@codecov
Copy link

@codecov codecov bot commented Jul 11, 2020

Codecov Report

No coverage uploaded for pull request base (master@f8d46a9). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1031   +/-   ##
=========================================
  Coverage          ?   98.46%           
=========================================
  Files             ?       25           
  Lines             ?     1040           
  Branches          ?        0           
=========================================
  Hits              ?     1024           
  Misses            ?       16           
  Partials          ?        0           
Impacted Files Coverage Δ
lib/layouts.js 99.05% <0.00%> (ø)
lib/appenders/stderr.js 100.00% <0.00%> (ø)
lib/appenders/noLogFilter.js 100.00% <0.00%> (ø)
lib/appenders/console.js 100.00% <0.00%> (ø)
lib/levels.js 100.00% <0.00%> (ø)
lib/appenders/recording.js 100.00% <0.00%> (ø)
lib/logger.js 97.82% <0.00%> (ø)
lib/appenders/multiFile.js 94.11% <0.00%> (ø)
lib/appenders/tcp.js 91.30% <0.00%> (ø)
lib/appenders/categoryFilter.js 100.00% <0.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8d46a9...e14876a. Read the comment docs.

@lamweili lamweili added this to the 6.4.0 milestone Jan 5, 2022
@lamweili lamweili merged commit 855143b into log4js-node:master Jan 10, 2022
1 check passed
@lamweili lamweili changed the title fix: file appender types fix(types): file appender types Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants