Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): add level parameter declaration to Logger.log function #1115

Merged
merged 2 commits into from Jan 11, 2022

Conversation

ZLundqvist
Copy link
Contributor

@ZLundqvist ZLundqvist commented Jan 7, 2022

Minor typedef improvement that better reflects the implementation, and also helps guide TypeScript developers using Logger.log.

@lamweili lamweili linked an issue Jan 9, 2022 that may be closed by this pull request
@lamweili lamweili added this to the 6.4.0 milestone Jan 9, 2022
Copy link
Contributor

@lamweili lamweili left a comment

Might want to remove the extra spacing between string and ,

@lamweili lamweili assigned lamweili and unassigned lamweili Jan 10, 2022
@ZLundqvist ZLundqvist requested a review from lamweili Jan 10, 2022
@lamweili lamweili merged commit 29e6949 into log4js-node:master Jan 11, 2022
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants