Synchronous File Appender #164

Merged
merged 3 commits into from Jul 12, 2014

Conversation

Projects
None yet
2 participants
Contributor

mayconbordin commented Dec 6, 2013

No description provided.

Collaborator

nomiddlename commented Dec 12, 2013

Thanks for this, any chance of some tests to cover it?

added tests for the fileSync appender and changed the behavior of fil…
…eSync to create an empty log when called, just like the file appender does
Contributor

mayconbordin commented Dec 12, 2013

Ok, tests created. I used the same test cases of the file appender, but I removed the 'exit listener' test because the fileSync appender doesn't open files or streams, so there's no reason to check that, the same applies to the 'when underlying stream errors'.

@nomiddlename nomiddlename merged commit 7fcdb2e into log4js-node:master Jul 12, 2014

1 check failed

default The Travis CI build failed
Details
Collaborator

nomiddlename commented Jul 12, 2014

Thanks for this - sorry it took me so long to merge.

Contributor

mayconbordin commented Jul 12, 2014

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment