New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client library should close session on exit #116

Closed
ongardie opened this Issue Mar 18, 2015 · 0 comments

Comments

Projects
None yet
1 participant
@ongardie
Copy link
Member

ongardie commented Mar 18, 2015

Currently, client sessions are only expired based on time. Especially with the command-line client (Examples/TreeOps) which is very short-lived, it'd be nice to have these sessions expired on a best-effort basis when a client exits.

@ongardie ongardie added the wishlist label Mar 18, 2015

@ongardie ongardie self-assigned this May 29, 2015

@ongardie ongardie closed this in 1a25468 Jun 16, 2015

nhardt pushed a commit to nhardt/logcabin that referenced this issue Aug 21, 2015

Add mechanism for clients to close their sessions cleanly on shutdown
From the release notes:
Clients now make a best effort attempt to close their sessions when they
shut down gracefully (issue logcabin#116). Before, client sessions were only
ever expired after a timeout. This state could accumulate quickly when
running short-lived clients in a tight loop. Enabling this change
requires all servers to be updated (so that the state machine is
updated); new clients talking to old clusters will issue a warning that
they are unable to close their sessions.

Close logcabin#116: client library should close session on exit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment