New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SegmentedLog should coalesce adjacent fdatasync calls #165

Closed
ongardie opened this Issue Jun 5, 2015 · 0 comments

Comments

Projects
None yet
1 participant
@ongardie
Copy link
Member

ongardie commented Jun 5, 2015

In SegmentedLog, write + fdatasync + write + fdatasync for the same file descriptor should be merged into write + write + fdatasync. This was lost in the cleanup before it got merged, and it's really important for performance.

@ongardie ongardie added the perf label Jun 5, 2015

@ongardie ongardie self-assigned this Jun 5, 2015

@ongardie ongardie closed this in cd820cb Jun 5, 2015

nhardt pushed a commit to nhardt/logcabin that referenced this issue Aug 21, 2015

Optimize SegmentedLog to elide common fdatasync calls
This should help a lot with disk performance (though I haven't
benchmarked it).

Close logcabin#165: SegmentedLog should coalesce adjacent fdatasync calls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment