New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client keepalive shouldn't prevent client programs from exiting #71

Closed
ongardie opened this Issue Dec 8, 2014 · 1 comment

Comments

Projects
None yet
1 participant
@ongardie
Copy link
Member

ongardie commented Dec 8, 2014

Steps to repro are the same as #70 but using latest master (37a53ec).

Instead of exiting, the client binary will hang forever (or until the client is finally able to talk to the LogCabin leader).

@ongardie

This comment has been minimized.

Copy link
Member

ongardie commented Dec 8, 2014

I think this would take care of the following TODO:

ClientImpl::ExactlyOnceRPCHelper::exit()
        // TODO(ongaro): would be better if we could cancel keep-alive calls

@ongardie ongardie self-assigned this Dec 8, 2014

ongardie added a commit that referenced this issue Dec 9, 2014

Add distinct status code for canceled RPCs
This allows users of ClientRPC to distinguish between failed RPCs and
those that have been canceled by the client.

Towards #71: client keepalive shouldn't prevent client programs from
exiting

@ongardie ongardie closed this in e3b2a0d Dec 9, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment