Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spec tests and some minor cleanup #10

Merged
merged 3 commits into from May 22, 2015
Merged

Conversation

@adamcrews
Copy link
Contributor

@adamcrews adamcrews commented Apr 23, 2015

This is a rather large PR that adds unit testing and does some minor cleanup.
The highlights are:

  • Functionally identical to the main master branch.
  • Switches to the newer metadata.yaml instead of the old Modulefile for forge info.
  • Adds unit tests
  • Adds travis.yaml for travis ci testing (a build of this commit can be seen at https://travis-ci.org/adamcrews/Loggly-Puppet/builds/59674347)
  • Adds class parameter validation
  • removes util::line in favor of puppet/stdlib file_line
  • compatibility checks for Puppet 4 and the future parser
  • bumps

This PR obsoletes #9

I am running this version in my production environment without issue.

@mostlyjason
Copy link
Contributor

@mostlyjason mostlyjason commented May 22, 2015

Thanks Adam! Unfortunately, our Puppet expert isn't available so we'll have to trust your tests. I still think it's good to release what you have. We'll just have to keep an eye on anything that pops up.

mostlyjason pushed a commit that referenced this pull request May 22, 2015
Add spec tests and some minor cleanup
@mostlyjason mostlyjason merged commit 53eb520 into loggly:master May 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.