Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Account for newer version of rsyslog, and custom app name #14
Conversation
|
@psquickitjayant can you review this when you get a chance? |
coreone
changed the title
* Update rsyslog.pp to choose correct template for version * Add more parameters for rsyslog in params.pp * Whitespace in init.pp * Add tests for new parameters to rsyslog_spec.rb * Correct some spacing in loggly.conf.erb * Allow for adding a custom "app-name" field to the output template * Update documentation comments in rsyslog.pp * Add updated tests for appname_string option * Make sure services restart on cert change
|
@psquickitjayant @mostlyjason had to update this today to make the syslog service (either rsyslog or syslog_ng) restart if the certificate changed due to the Loggly cert change that happens today. If the restart doesn't happen, rsyslog won't be refreshed with the corrected certificate chain. Please test as soon as possible as this has been hanging out in here for quite a long time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Some of the syntax and configuration suggestions have changed for rsyslog > 5. For example,
templateandactionare now completely different, and there is now a block of$ActionQueuesettings that are suggested for each remote syslog configuration. I was having trouble getting some logs to ship, and updating the configuration with those$ActionQueuesettings fixed the issue for me.Additionally, I added some tests for some new parameters I added (so that the
$ActionQueuesettings are customizable) and tried to run the tests, but the tests seem to be broken in some way. I ran the tests on master and most of them failed, so either the standardbundle install; bundle exec rake testprocess doesn't work on my machine (which it does for other modules) or something else is going on with the tests.