Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Refactor to allow logfile to work properly #4
Conversation
loggly::syslog_ng could cause duplicate declaration of /etc/syslog-ng/conf.d
Fix typo in project_page by separating loggly and puppet with a dash
Ensure that SSL certificates are in place before restarting rsyslog
loggly::syslog_ng should check conf.d declaration
|
Adam sorry its taken so long to review this. We merged several PRs but yours has a version conflict. Do you think you can address the conflict and resubmit? |
|
No worries, I'll rebase and get things all fixed up. |
|
@adamcrews any estimate on when you might get a chance to clean it up? if it's going to be a while we might be able to help |
|
@mostlyjason I've rebased. It looks good to me to merge, but I have only very briefly tested it. |
mostlyjason
pushed a commit
that referenced
this pull request
Apr 22, 2015
Refactor to allow logfile to work properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This is a simple refactor of the logfile define that so that it adheres to the style guide.