Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Fix collectd metric processing #3
Conversation
… each metric, and types.db metric name lookups
First, we look at the system installed types.db (works on centos package, should probably be generalized). Later, we split up the metric name into is parts according to the collectd data spec. The instance are split out and handled somewhat better. This fixes an issue where type instances will break the lookup in the types.db file. This also fixes an issue where metrics will be poorly named when they appear in graphite. CAVEAT: This makes changes that are not compatible with existing proxy users. The graphs will be given different names. tl:dr This breaks backwards compatability
Fix collectd metric processing
|
I was using it at loggly for a while, but I didn't have energy to fix how I configured graphite, so I shutdown graphite and this tool for a time. It'll be in use again soon. As for dropping metrics, That wasn't something I noticed but should have checked for. Thanks for the patch :) |
This comment has been minimized.
This comment has been minimized.
|
I've never seen slashes in collectd names? Hmm... |
This comment has been minimized.
This comment has been minimized.
|
That bit of the code came from @donjohnson. In the collectd PUTVAL (or command) format, slashes are used to separate the parts of the metric. Graphite uses "." for the same purpose, so it is switched there. For reference: |
This comment has been minimized.
This comment has been minimized.
|
Nod, will keep this code as-is until I get a chance to play with it again. Thanks :) |
This comment has been minimized.
This comment has been minimized.
|
I'll make this a flag later. |
This comment has been minimized.
This comment has been minimized.
|
Yeah, that would be better, but I was in hack mode. |
This pull request may not actually make sense for loggly to pull, but I will put it out there.
THIS IS NOT BACKWARDS COMPATIBLE. It will put graphs in new and interesting locations.
Basically this allows the proxy to fully understand the data that it is reading.