This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Handle Fragmentation, small fixes #5
Closed
Conversation
added 3 commits
Aug 26, 2011
@donjohnson checked this file in, but my changes made it less useful.
Collectd had a bad habit of fragmenting messages. In short, it will send two POSTS that are meant to be handled together. In some cases, these POSTS will each contain part of a single line of data. This logic stores fragments for the next POST to put back together. It discards the fragment from the first POST because it sometimes is complete enough to parse and really mess up the DB. Fragmentation seems to be discoverable by looking for a lack of blank line at the end of the first POST. Example fragments: First POST, last line: PUTVAL host.example.com/disk-d Second POST, first line: m-0/disk_octets interval=10 1314724861:654568
|
@jordansissel I think it almost works now :) |
|
Cleaning up ancient/stale pull requests |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This commit primarily fixes a relatively bad fragmentation issue in the collectd messages.
When the fragmentation occurs, data is corrupted. The most common symptom is COUNTER type values suddenly loosing a few orders of magnitude (really messes up derivative calculations).
Other commits remove old files, and improve docs a bit.