• Remove Strings#splitStringToArray

    This commit removes the method Strings#splitStringToArray and replaces
    the call sites with invocations to String#split. There are only two
    explanations for the existence of this method. The first is that
    String#split is slightly tricky in that it accepts a regular expression
    rather than a character to split on. This means that if s is a string,
    s.split(".")  does not split on the character '.', but rather splits on
    the regular expression '.' which splits on every character (of course,
    this is easily fixed by invoking s.split("\\.") instead). The second
    possible explanation is that (again) String#split accepts a regular
    expression. This means that there could be a performance concern
    compared to just splitting on a single character. However, it turns out
    that String#split has a fast path for the case of splitting on a single
    character and microbenchmarks show that String#split has 1.5x--2x the
    throughput of Strings#splitStringToArray. There is a slight behavior
    difference between Strings#splitStringToArray and String#split: namely,
    the former would return an empty array in cases when the input string
    was null or empty but String#split will just NPE at the call site on
    null and return a one-element array containing the empty string when the
    input string is empty. There was only one place relying on this behavior
    and the call site has been modified accordingly.
    jasontedor committed May 4, 2016