Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
added function to check all dependencies #102
Conversation
| @@ -945,7 +948,7 @@ checkIfTLS() | |||
| esac | |||
| done | |||
| else | |||
| logMsgToConfigSysLog "WARN" "WARN: Your system logs are being send insecurely. We prefer to send system logs securely so switching to secure configuration." | |||
| logMsgToConfigSysLog "WARN" "WARN: Your system logs are being sent insecurely. We prefer to send the system logs securely so switching to the secure configuration." | |||
Shwetajain148
Sep 4, 2017
Author
Contributor
@mostlyjason, This is the else part of the same checkIfTLS function and this message will be displayed if the suppress mode is on. It means whenever the user will run the script in insecure mode with the suppress flag then the script will not ask to switch to secure mode instead will copy the secure configuration by default.
@mostlyjason, This is the else part of the same checkIfTLS function and this message will be displayed if the suppress mode is on. It means whenever the user will run the script in insecure mode with the suppress flag then the script will not ask to switch to secure mode instead will copy the secure configuration by default.
mostlyjason
Sep 5, 2017
Contributor
The problem seems unclear to me can you remove this change and put in a separate JIRA issue?
The problem seems unclear to me can you remove this change and put in a separate JIRA issue?
| @@ -932,7 +935,7 @@ checkIfTLS() | |||
| if [ "$SUPPRESS_PROMPT" == "false" ]; then | |||
| while true; | |||
| do | |||
| read -p "Hey you are going to setup system logs in insecure mode. Do you want to overwrite this with secure mode? (yes/no)" yn | |||
| read -p "Hey, you are going to setup the system logs in insecure mode. Do you want to overwrite this with secure mode? (yes/no)" yn | |||
Shwetajain148
Sep 4, 2017
Author
Contributor
@mostlyjason, This prompt will occur whenever the user will run the script in insecure mode or the script is going to set the NON-TLS configuration i.e. port 514.
If the user enter yes then it means he wants to setup secure logging so the TLS configurations will be copied i.e. port 6514 otherwise the insecure configurations will be copied i.e. port 514 on entering no.
@mostlyjason, This prompt will occur whenever the user will run the script in insecure mode or the script is going to set the NON-TLS configuration i.e. port 514.
If the user enter yes then it means he wants to setup secure logging so the TLS configurations will be copied i.e. port 6514 otherwise the insecure configurations will be copied i.e. port 514 on entering no.
mostlyjason
Sep 5, 2017
Contributor
The problem seems unclear to me can you remove this change and put in a separate JIRA issue?
The problem seems unclear to me can you remove this change and put in a separate JIRA issue?
@mchaudhary @mostlyjason In this PR, I have added a new function that will check if the required dependencies to run the script are not installed. I also did some refactoring work like function name changes etc. Please review.