Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added function to check all dependencies #102

Merged
merged 5 commits into from Oct 10, 2017
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Refactor

  • Loading branch information
EC2 Default User
EC2 Default User committed Sep 1, 2017
commit 80d1d051afc47b548721db30b4e50483ad4bbfd3
@@ -935,7 +935,7 @@ checkIfTLS()
if [ "$SUPPRESS_PROMPT" == "false" ]; then
while true;
do
read -p "Hey you are going to setup system logs in insecure mode. Do you want to overwrite this with secure mode? (yes/no)" yn
read -p "Hey, you are going to setup the system logs in insecure mode. Do you want to overwrite this with secure mode? (yes/no)" yn

This comment has been minimized.

@mostlyjason

mostlyjason Sep 1, 2017
Contributor

@Shwetajain148 what conditions cause this message to be displayed?

This comment has been minimized.

@Shwetajain148

Shwetajain148 Sep 4, 2017
Author Contributor

@mostlyjason, This prompt will occur whenever the user will run the script in insecure mode or the script is going to set the NON-TLS configuration i.e. port 514.

If the user enter yes then it means he wants to setup secure logging so the TLS configurations will be copied i.e. port 6514 otherwise the insecure configurations will be copied i.e. port 514 on entering no.

This comment has been minimized.

@mostlyjason

mostlyjason Sep 5, 2017
Contributor

The problem seems unclear to me can you remove this change and put in a separate JIRA issue?

case $yn in
[Yy]* )
logMsgToConfigSysLog "INFO" "INFO: Going to overwrite the conf file: $LOGGLY_RSYSLOG_CONFFILE with secure configuration";
@@ -948,7 +948,7 @@ checkIfTLS()
esac
done
else
logMsgToConfigSysLog "WARN" "WARN: Your system logs are being send insecurely. We prefer to send system logs securely so switching to secure configuration."
logMsgToConfigSysLog "WARN" "WARN: Your system logs are being sent insecurely. We prefer to send the system logs securely so switching to the secure configuration."

This comment has been minimized.

@mostlyjason

mostlyjason Sep 1, 2017
Contributor

@Shwetajain148 what conditions cause this message to be displayed?

This comment has been minimized.

@Shwetajain148

Shwetajain148 Sep 4, 2017
Author Contributor

@mostlyjason, This is the else part of the same checkIfTLS function and this message will be displayed if the suppress mode is on. It means whenever the user will run the script in insecure mode with the suppress flag then the script will not ask to switch to secure mode instead will copy the secure configuration by default.

This comment has been minimized.

@mostlyjason

mostlyjason Sep 5, 2017
Contributor

The problem seems unclear to me can you remove this change and put in a separate JIRA issue?

LOGGLY_TLS_SENDING="true"
LOGGLY_SYSLOG_PORT=6514

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.