Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
New flags logging support #103
Merged
Conversation
and others
added 2 commits
Sep 8, 2017
|
@mchaudhary @mostlyjason I have corrected the insecure parameter name from secure-sending to insecure-mode. Please review. |
|
Looks good to me. @mchaudhary can merge when he's ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
@mchaudhary, @mostlyjason, In this PR, I have added 4 new fields listed below to get logged on Loggly-
Please note that all below fields contain the value either in true or false so we can easily identify which flag was used when the user ran the command by looking at its value on Loggly Search UI.
secure-sending - This field will tell whether the script ran in the secure mode or in a insecure mode.
suppress-enabled - This field will tell whether the script ran in suppress mode or not.
force-secure-enabled - This field will tell whether the script ran in --force-secure mode or not.
loggly-removed - This field will tell if the user has removed the Loggly configuration from his machine.
Please review.