Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Check and switch existing logging mode #104
Conversation
| if [ -f $LOGGLY_RSYSLOG_CONFFILE ]; then | ||
| if [[ $RSYSLOG_VERSION_TMP -le "7" ]]; then | ||
| EXISTING_SYSLOG_PORT=$(grep 6514 $LOGGLY_RSYSLOG_CONFFILE | awk {'print $2'} | cut -d':' -f2 | cut -d';' -f1) | ||
| elif [[ "$RSYSLOG_VERSION_TMP" -ge "8" ]]; then |
mostlyjason
Sep 18, 2017
Contributor
I'm not sure you should switch this off the version number, since the newer versions are also compatible with the legacy syntax
I'm not sure you should switch this off the version number, since the newer versions are also compatible with the legacy syntax
Shwetajain148
Sep 19, 2017
Author
Contributor
@mostlyjason Actually the TLS configuration for rsyslog version less than 7 and greater than 8 is different and since I need to grep the port 6514 from the TLS configuration of 22-loggly.conf file, I had to use two grep commands to grep port 6514 from different places in both the configurations.
TLS configuration for rsyslog version less than 7 can be see here- https://github.com/loggly/install-script/blob/master/Linux%20Script/configure-linux.sh#L521-L546
TLS configuration for rsyslog version greater than 8 can be see here- https://github.com/loggly/install-script/blob/master/Linux%20Script/configure-linux.sh#L549-L569
That is why I used two different commands to grep the 6514 port based on rsyslog versions.
Also, the NON-TLS configuration is same for any rsyslog version so I used only one grep command to pick the port 514 from 22-loggly.conf file.
@mostlyjason Actually the TLS configuration for rsyslog version less than 7 and greater than 8 is different and since I need to grep the port 6514 from the TLS configuration of 22-loggly.conf file, I had to use two grep commands to grep port 6514 from different places in both the configurations.
TLS configuration for rsyslog version less than 7 can be see here- https://github.com/loggly/install-script/blob/master/Linux%20Script/configure-linux.sh#L521-L546
TLS configuration for rsyslog version greater than 8 can be see here- https://github.com/loggly/install-script/blob/master/Linux%20Script/configure-linux.sh#L549-L569
That is why I used two different commands to grep the 6514 port based on rsyslog versions.
Also, the NON-TLS configuration is same for any rsyslog version so I used only one grep command to pick the port 514 from 22-loggly.conf file.
| case $yn in | ||
| [Yy]* ) | ||
| logMsgToConfigSysLog "INFO" "INFO: Going to overwrite the conf file: $LOGGLY_RSYSLOG_CONFFILE with insecure configuration"; | ||
| LOGGLY_TLS_SENDING="false" |
@mchaudhary @mostlyjason, In this PR, I am checking whether the user is running the dependent scripts in secure or insecure mode, based on the script running mode, I am checking if the existing port in 22-loggly.conf file is same as the running mode of the script For example if the user is running the file-monitoring script in secure mode but 22-loggly.conf is set with insecure config then the script will prompt to switch system config to secure mode as well and vice versa.
Please review.