Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Add admin args option #114
Conversation
|
Thanks @kevinegami ! Code changes look good to me. I have tried to run the updated script on my machine(windows 10). I am getting an exception below Traceback (most recent call last):
File "SQS3script.py", line 59, in <module>
with open(os.environ['HOME'] + '/.aws/credentials') as f:
File "C:\Python27\lib\os.py", line 425, in __getitem__
return self.data[key.upper()]
KeyError: 'HOME' I am also getting same exception with the script which is already in production. It seems like machine environment issue. I will give another try on linux(ubuntu) machine tomorrow and will update you. |
|
The issue mentioned above was broken before this PR, due to the script assuming to be run in a unix environment. I have a PR fix here: #115 |
|
We have checked with updated script, link and successfully able to get the logs in QA Environment. Please let us know if there are any test cases need to perform on this. |
AWS CLI
.aws/credentialscan have more than one user. Previously, the script would default to the last set of access/secret keys, which may not have administrative privileges. If the user does have multiple users, this will allow them to pass in the admin name with administrative permissions.Note: This is different than "user" which will have access to the s3 bucket and not necessarily have admin privileges.
@Shwetajain148 can you please review. Can you email Pankaj to test as well after approval/merge.
Thank you