Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
use "curl -L" to follow redirects during subdomain check #121
Conversation
also write out http_code to avoid using grep to check for 200
|
sorry to say, but unfortunately this is not correct solution:
still outputs 200. This is due to invalid subdomain follows redirect to an error page, which surprisingly returns 200 and html code.... |
|
@OndrejCholeva @nguyenfilip I originally made this PR because our scripts were failing at this subdomain check step - a 302 is seen because loggly now redirects to another page for auth. I had no idea that an invalid subdomain redirects to a valid error page! We can use curl's -w again here though, to check that the redirect isn't invalid:
I'll make another PR with this check. |
|
Nevermind, #122 handles it :) ninja edit: @OndrejCholeva is quicker on the draw :) |
also write out http_code to avoid using grep to check for 200