Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOG-5184: fix and refactor the script for setting up S3 ingestion #125

Merged
merged 6 commits into from Aug 19, 2019

Conversation

@MichalChomo
Copy link
Contributor

@MichalChomo MichalChomo commented Jul 26, 2019

No description provided.

@MichalChomo MichalChomo changed the title LOG-5184: fix S3 bucket detection and refactor LOG-5184: fix and refactor the script for setting up S3 ingestion Jul 26, 2019
@MichalChomo MichalChomo requested a review from vonnagy Aug 1, 2019
@vonnagy
vonnagy approved these changes Aug 6, 2019
Copy link

@vonnagy vonnagy left a comment

LGTM

@jfojtl
Copy link

@jfojtl jfojtl commented Aug 7, 2019

LGTM AW. Did not test however.

@jfojtl
jfojtl approved these changes Aug 7, 2019
@MichalChomo
Copy link
Contributor Author

@MichalChomo MichalChomo commented Aug 7, 2019

Thanks for the review, I want to do some more changes though. And after that, I will also test this.

@MichalChomo MichalChomo added the wip label Aug 7, 2019
@MichalChomo MichalChomo removed the wip label Aug 16, 2019
@MichalChomo MichalChomo requested review from jfojtl and vonnagy Aug 16, 2019
Copy link

@vonnagy vonnagy left a comment

LGTM

@MichalChomo MichalChomo merged commit fbed1e9 into master Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.