Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Update to improve Syslog daemon detection. #26
Merged
Conversation
added 4 commits
Aug 30, 2013
We don't need to keep adding 1 to an index var. We can just have `enumerate()` start at 1 instead of 0
* No longer need to figure out distro before we decide to run `dpkg` or `rpm` to find which version of a daemon we are running * Add test for replacement method that detects the syslog daemon.
…pdates Conflicts: configure-syslog.py
rhigdon
pushed a commit
that referenced
this pull request
Aug 31, 2013
Update to improve Syslog daemon detection.
| for i, version in enumerate(current_environment['syslog_versions']): | ||
| line = "\t%d. %s(%s)" % (i + 1, version[0], version[1]) | ||
| Logger.printLog(line, print_comp = True) | ||
| for i, version in enumerate(current_environment['syslog_versions'], 1): |
MichaelBlume
Aug 31, 2013
Contributor
nice
nice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.