Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
LOGGLY-3903 Remove prompts to run 'verify' action #33
Conversation
When users run the install script as shown in our docs, the install-script is never saved to disk, so users cannot re-run the script with any 'verify' action. We should not advertise an action they cannot run without re-downloading the script.
| return syslog_name_for_configuration | ||
|
|
||
| def verify(current_environment): | ||
| Logger.printLog("Verification started", prio = 'debug') | ||
|
|
philip-loggly
Sep 3, 2013
Contributor
Nitpick: Do you really want all these blank lines in here?
Nitpick: Do you really want all these blank lines in here?
ivangonekrazy
Sep 3, 2013
Author
Contributor
yes, that block was a pain to read at a glance.
the perform_sanity_check_and_get_product_for_configuration() function call and the tuple destructuring immediately following it made the loggly_user variable et al. appear to be params of said function call.
yes, that block was a pain to read at a glance.
the perform_sanity_check_and_get_product_for_configuration() function call and the tuple destructuring immediately following it made the loggly_user variable et al. appear to be params of said function call.
philip-loggly
Sep 3, 2013
Contributor
The function is now formatted completely differently relative to the rest of the script. I don't think we should do this. Unless I am missing something?
The function is now formatted completely differently relative to the rest of the script. I don't think we should do this. Unless I am missing something?
philip-loggly
Sep 3, 2013
Contributor
Perhaps we could at least group the 3 middle lines together, the guts of the thing.
Perhaps we could at least group the 3 middle lines together, the guts of the thing.
LOGGLY-3903 Remove prompts to run 'verify' action
When users run the install script as shown in our docs, the
install-script is never saved to disk, so users cannot re-run the
script with any 'verify' action.
We should not advertise an action they cannot run without
re-downloading the script.