When users run the install script as shown in our docs, the
install-script is never saved to disk, so users cannot re-run the
script with any 'verify' action.
We should not advertise an action they cannot run without
re-downloading the script.
the perform_sanity_check_and_get_product_for_configuration() function call and the tuple destructuring immediately following it made the loggly_user variable et al. appear to be params of said function call.
The function is now formatted completely differently relative to the rest of the script. I don't think we should do this. Unless I am missing something?
ProTip!
Use n and p to navigate between commits in a pull request.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.
We use optional third-party analytics cookies to understand how you use GitHub.com so we can build better products.
Learn more.
We use optional third-party analytics cookies to understand how you use GitHub.com so we can build better products.
You can always update your selection by clicking Cookie Preferences at the bottom of the page.
For more information, see our Privacy Statement.
Essential cookies
We use essential cookies to perform essential website functions, e.g. they're used to log you in.
Learn more
Always active
Analytics cookies
We use analytics cookies to understand how you use our websites so we can make them better, e.g. they're used to gather information about the pages you visit and how many clicks you need to accomplish a task.
Learn more
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LOGGLY-3903 Remove prompts to run 'verify' action #33
LOGGLY-3903 Remove prompts to run 'verify' action #33
Changes from 1 commit
ae74e4c3d3196eFile filter...
Jump to…
LOGGLY-3903 Remove prompts to run 'verify' action
philip-logglySep 3, 2013
Contributor
Nitpick: Do you really want all these blank lines in here?
ivangonekrazySep 3, 2013
Author
Contributor
yes, that block was a pain to read at a glance.
the
perform_sanity_check_and_get_product_for_configuration()function call and the tuple destructuring immediately following it made theloggly_uservariable et al. appear to be params of said function call.philip-logglySep 3, 2013
Contributor
The function is now formatted completely differently relative to the rest of the script. I don't think we should do this. Unless I am missing something?
philip-logglySep 3, 2013
Contributor
Perhaps we could at least group the 3 middle lines together, the guts of the thing.