Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmetic changes to script #55

Merged
merged 3 commits into from Nov 21, 2013
Merged

Cosmetic changes to script #55

merged 3 commits into from Nov 21, 2013

Conversation

@philip-loggly
Copy link
Contributor

@philip-loggly philip-loggly commented Nov 21, 2013

No description provided.

@philip-loggly
Copy link
Contributor Author

@philip-loggly philip-loggly commented Nov 21, 2013

Need this pulled ASAP.

@@ -976,7 +976,7 @@ def modify_syslog_config_file(syslog_id, syslog_configuration_details,

if len(syslog_configuration_details.get("token")) <= 0:
question = ("\nThe Loggly configuration will be appended to (%s) file."
"\n\nDo you want this installer to modify "
"\n\nDo you want this setup-script to modify "

This comment has been minimized.

@vinhn

vinhn Nov 21, 2013

How about: "Would you like to have the configuration file modified?"

If not, "setup script" is fine...without the dash in between.

@@ -1427,14 +1427,14 @@ def parse_args(self, *args, **kwargs):
CMD_USAGE = '''
%prog <action> [option]
Action:
\tinstall Configure the syslog
\tuninstall Remove changes made by the syslog configuration script
\tsetup Configure your syslog installtion

This comment has been minimized.

@vinhn

vinhn Nov 21, 2013

"installtion" is missing an "a". For consistency though, this should perhaps read as: "Configure your syslog setup"

\tinstall Configure the syslog
\tuninstall Remove changes made by the syslog configuration script
\tsetup Configure your syslog installtion
\trevert Remove changes made by the syslog configuration script

This comment has been minimized.

@vinhn

vinhn Nov 21, 2013

...made by this syslog configuration script.

@philip-loggly
Copy link
Contributor Author

@philip-loggly philip-loggly commented Nov 21, 2013

Vinh -- thanks for the proofreading.

Ticket: LOGGLY-4252
@philip-loggly
Copy link
Contributor Author

@philip-loggly philip-loggly commented Nov 21, 2013

With Vinh's review comments addressed, I am going to self-merge this. Due to deployed FrontEnd changes, our current script doesn't work -- so this is hot.

philip-loggly added a commit that referenced this pull request Nov 21, 2013
@philip-loggly philip-loggly merged commit 631994a into loggly:master Nov 21, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.