Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Added username/ password verification #60
Conversation
Added username/ password verification
| else | ||
| logMsgToConfigSysLog "WARNING" "WARNING: logs-01.loggly.com is not reachable. Please check your network and firewall settings. Continuing to configure Loggly on your system..." | ||
| fi | ||
| if [ $(curl -s -u $LOGGLY_USERNAME:$LOGGLY_PASSWORD http://$LOGGLY_ACCOUNT.loggly.com/apiv2/customer | grep "Unauthorized" | wc -l) == 1 ]; then |
vinhn
May 8, 2014
Ok to send password in clear text over unencrypted connection? Should this be over https instead?
Ok to send password in clear text over unencrypted connection? Should this be over https instead?
mchaudhary
May 8, 2014
Contributor
Great catch. This should be over https. I will fix it.
Great catch. This should be over https. I will fix it.
| fi | ||
|
|
||
| echo "Checking if logs-01.loggly.com is reachable" | ||
| if [ $(ping -c 1 logs-01.loggly.com | grep "1 packets transmitted, 1 received, 0% packet loss" | wc -l) == 1 ]; then |
vinhn
May 8, 2014
Many of these urls should be defined as variables/constants at the top of the script, instead of being embedded into these functions. Users who care about security will definitely look at this script before they actually execute it. A nicely constructed script that gives clear visibility into what it is doing will automatically win over trust on a user's part. A complex script will do the exact opposite and can increase the chance of it not being used.
Many of these urls should be defined as variables/constants at the top of the script, instead of being embedded into these functions. Users who care about security will definitely look at this script before they actually execute it. A nicely constructed script that gives clear visibility into what it is doing will automatically win over trust on a user's part. A complex script will do the exact opposite and can increase the chance of it not being used.
No description provided.