Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Incorporated Vihn's Feedback #62
Merged
Conversation
| #version of the current script | ||
| SCRIPT_VERSION=1.0 | ||
| #token to log to config syslog | ||
| CONFIG_SYSLOG_TOKEN=1ec4e8e1-fbb2-47e7-929b-75a1bff5ffe0 |
mchaudhary
May 9, 2014
Contributor
This is scary we can't have our token in plain text here may be you base64encode it. It is pretty easy you can use base64. I created Jira for this one so can be tracked there.
This is scary we can't have our token in plain text here may be you base64encode it. It is pretty easy you can use base64. I created Jira for this one so can be tracked there.
| MIN_SYSLOG_VERSION=5.8.0 | ||
|
|
||
| #name of the service, in this case tomcat6 | ||
| SERVICE=tomcat6 |
mchaudhary
May 9, 2014
Contributor
Here also we should default to tomcat6 but if detect this one to be 7 then change it. This is minor one. Please log a bug for it.
Here also we should default to tomcat6 but if detect this one to be 7 then change it. This is minor one. Please log a bug for it.
| logMsgToConfigSysLog "ERROR" "ERROR: Invalid Loggly username or password" | ||
| exit 1 | ||
| else | ||
| echo "INFO: Username and password authorized successfully" |
mchaudhary
May 9, 2014
Contributor
We should log this to logMsgToConfigSysLog as well
We should log this to logMsgToConfigSysLog as well
mchaudhary
added a commit
that referenced
this pull request
May 9, 2014
Incorporated Vihn's Feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.