Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flush messages on close #12

Closed

Conversation

@richardnagle
Copy link

@richardnagle richardnagle commented Oct 30, 2017

This PR will ensure that on appender shutdown all queued messages are sent to loggly.

@mostlyjason
Copy link

@mostlyjason mostlyjason commented Oct 30, 2017

Thanks @richardnagle! We'll review this when our engineer gets a chance.

@abedra
Copy link

@abedra abedra commented Mar 20, 2018

@mostlyjason when do you expect to merge this?

@YouGitMoreWithLes
Copy link

@YouGitMoreWithLes YouGitMoreWithLes commented Jul 22, 2018

I would really like to see this get merged and released. I have a few console applications using this dependency and I must add a wait loop until the timer fires to flush the logs.

@Katulus Katulus self-requested a review Nov 14, 2018
@Katulus
Copy link

@Katulus Katulus commented Nov 14, 2018

The current implementation still does not guarantee that all logs are sent. Because messages are taken out of queue before they are sent over the wire the Flush call can return before logs are really sent over the wire. If you then terminate application you lose logs.

We plan to do some refactoring of this so we'll try to include proper flush on shutdown.

@Katulus
Copy link

@Katulus Katulus commented Jan 29, 2019

New version (beta) has been just released. You can get it on https://github.com/loggly/log4net-loggly/releases/tag/v9.0.0-beta1 or via Nuget. It's almost complete rewrite and flush-on-shutdown is now included.

@Katulus Katulus closed this Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.