Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Flush messages on close #12
Conversation
…all messages are sent
|
Thanks @richardnagle! We'll review this when our engineer gets a chance. |
|
@mostlyjason when do you expect to merge this? |
|
I would really like to see this get merged and released. I have a few console applications using this dependency and I must add a wait loop until the timer fires to flush the logs. |
|
The current implementation still does not guarantee that all logs are sent. Because messages are taken out of queue before they are sent over the wire the We plan to do some refactoring of this so we'll try to include proper flush on shutdown. |
|
New version (beta) has been just released. You can get it on https://github.com/loggly/log4net-loggly/releases/tag/v9.0.0-beta1 or via Nuget. It's almost complete rewrite and flush-on-shutdown is now included. |
This PR will ensure that on appender shutdown all queued messages are sent to loggly.